Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1219673002: Avoid multiline string literal in svgelement test. (Closed)

Created:
5 years, 5 months ago by herhut
Modified:
5 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid multiline string literal in svgelement test. R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3b34c17909e96c90c35d860cb9fd300d776829dc

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M tests/html/svgelement_test.dart View 1 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
herhut
5 years, 5 months ago (2015-06-29 10:30:44 UTC) #1
Bill Hesse
LGTM. https://codereview.chromium.org/1219673002/diff/1/tests/html/svgelement_test.dart File tests/html/svgelement_test.dart (right): https://codereview.chromium.org/1219673002/diff/1/tests/html/svgelement_test.dart#newcode56 tests/html/svgelement_test.dart:56: '<svg xmlns="http://www.w3.org/2000/svg" version="1.1">\r\n ' Can you get rid ...
5 years, 5 months ago (2015-06-29 10:32:41 UTC) #2
herhut
On 2015/06/29 10:32:41, Bill Hesse wrote: > LGTM. > > https://codereview.chromium.org/1219673002/diff/1/tests/html/svgelement_test.dart > File tests/html/svgelement_test.dart (right): ...
5 years, 5 months ago (2015-06-29 10:38:41 UTC) #3
herhut
https://codereview.chromium.org/1219673002/diff/1/tests/html/svgelement_test.dart File tests/html/svgelement_test.dart (right): https://codereview.chromium.org/1219673002/diff/1/tests/html/svgelement_test.dart#newcode56 tests/html/svgelement_test.dart:56: '<svg xmlns="http://www.w3.org/2000/svg" version="1.1">\r\n ' On 2015/06/29 10:32:41, Bill Hesse ...
5 years, 5 months ago (2015-06-29 10:39:00 UTC) #4
herhut
5 years, 5 months ago (2015-06-29 10:39:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3b34c17909e96c90c35d860cb9fd300d776829dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698