Issue 1219623004: VM: Fix issue with optimizing compiler's range analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1219623004: VM: Fix issue with optimizing compiler's range analysis. (Closed)

Created:
5 years, 5 months ago by Florian Schneider

Modified:
5 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

VM: Fix issue with optimizing compiler's range analysis. Narrowing of ranges should only occur if the new range is actually narrower than the old range. It can happen that a symbolic range is worse than the already computed one. Ignore the new range in this case. BUG=dartbug.com/23693 R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/5daa5646ef8e09739778720aa27a89a26bd70aeb

Patch Set 1 #

Patch Set 2 : removed outdated comments #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
	M	runtime/vm/flow_graph_range_analysis.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Vyacheslav Egorov (Google)

LGTM it should be correct to me, though it might lead to inaccurate bounds (which ...

5 years, 5 months ago (2015-06-29 13:31:07 UTC) #3

Florian Schneider

Committed patchset #2 (id:20001) manually as 5daa5646ef8e09739778720aa27a89a26bd70aeb (presubmit successful).

5 years, 5 months ago (2015-06-29 14:14:10 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages