Issue 1219493007: Modify analysis server codegen check to tolerate Windows line endings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1219493007: Modify analysis server codegen check to tolerate Windows line endings. (Closed)

Created:
5 years, 5 months ago by Paul Berry

Modified:
5 years, 5 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Modify analysis server codegen check to tolerate Windows line endings. Now that the git repository config has been modified to use CR/LF on Windows machines, our generated files contain different contents on Windows machines than they do on Mac/Linux machines, so they were failing the codegen check. This CL updates the codegen check to tolerate those differences. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9857471f8c8e9b4b94d22ffcd00548cddc7b65d5

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	pkg/analysis_server/tool/spec/codegen_tools.dart	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 5 months ago (2015-07-01 18:12:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9857471f8c8e9b4b94d22ffcd00548cddc7b65d5 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages