Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 12192021: Revert "Remove Sink and move CollectionSink to async." (Closed)

Created:
7 years, 10 months ago by floitsch
Modified:
7 years, 10 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Remove Sink and move CollectionSink to async." This reverts commit 18063. Committed: https://code.google.com/p/dart/source/detail?r=18067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -82 lines) Patch
M pkg/http/lib/src/multipart_request.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/streamed_request.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/compiler.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2jslib.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/async/async.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/async/async_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/async/collection_sink.dart View 1 chunk +0 lines, -46 lines 0 comments Download
M sdk/lib/async/stream.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/core/core.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/core/corelib_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + sdk/lib/core/sink.dart View 2 chunks +19 lines, -16 lines 0 comments Download
M tests/lib/async/event_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
Probably a bad merge. TBR.
7 years, 10 months ago (2013-02-04 19:29:59 UTC) #1
ahe
7 years, 10 months ago (2013-02-04 19:31:44 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698