Issue 12191008: Get the pub oauth2 test passing locally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12191008: Get the pub oauth2 test passing locally. (Closed)

Created:
7 years, 10 months ago by nweiz

Modified:
7 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Get the pub oauth2 test passing locally. Committed: https://code.google.com/p/dart/source/detail?r=18103

Patch Set 1 #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -27 lines)			Patch
M	pkg/http/lib/src/byte_stream.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/utils.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	utils/pub/oauth2.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/utils.dart	View	2 chunks	+18 lines, -4 lines	0 comments	Download
M	utils/tests/pub/oauth2_test.dart	View	4 chunks	+11 lines, -4 lines	2 comments	Download
M	utils/tests/pub/test_pub.dart	View	6 chunks	+27 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion, but LGTM! https://codereview.chromium.org/12191008/diff/1/utils/tests/pub/oauth2_test.dart File utils/tests/pub/oauth2_test.dart (right): https://codereview.chromium.org/12191008/diff/1/utils/tests/pub/oauth2_test.dart#newcode36 utils/tests/pub/oauth2_test.dart:36: pub.shouldExit(1); Maybe add a pub.shouldFail(1) ...

7 years, 10 months ago (2013-02-05 00:53:22 UTC) #2

nweiz

7 years, 10 months ago (2013-02-05 00:57:17 UTC) #3

https://codereview.chromium.org/12191008/diff/1/utils/tests/pub/oauth2_test.dart
File utils/tests/pub/oauth2_test.dart (right):

https://codereview.chromium.org/12191008/diff/1/utils/tests/pub/oauth2_test.d...
utils/tests/pub/oauth2_test.dart:36: pub.shouldExit(1);
On 2013/02/05 00:53:22, Bob Nystrom wrote:
> Maybe add a pub.shouldFail(1) method so you don't have to repeat this comment?

I don't think that makes sense to put on the actual ScheduledProcess class. I
think the comment is infrequent enough to warrant repeating.

Expand Messages | Collapse Messages