Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1219073003: Add a Configuration class that encapsulates command-line configuration. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a Configuration class that encapsulates command-line configuration. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/cb1dea0ffca6d360870e327eec628ee19dedf437

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -138 lines) Patch
M lib/src/executable.dart View 10 chunks +45 lines, -137 lines 0 comments Download
A lib/src/runner/configuration.dart View 1 1 chunk +168 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 5 months ago (2015-07-02 01:22:57 UTC) #1
kevmoo
LGTM w/ a tiny nit https://codereview.chromium.org/1219073003/diff/1/lib/src/runner/configuration.dart File lib/src/runner/configuration.dart (right): https://codereview.chromium.org/1219073003/diff/1/lib/src/runner/configuration.dart#newcode24 lib/src/runner/configuration.dart:24: /// The parser used ...
5 years, 5 months ago (2015-07-02 04:24:45 UTC) #2
nweiz
Code review changes
5 years, 5 months ago (2015-07-06 20:15:08 UTC) #3
nweiz
https://codereview.chromium.org/1219073003/diff/1/lib/src/runner/configuration.dart File lib/src/runner/configuration.dart (right): https://codereview.chromium.org/1219073003/diff/1/lib/src/runner/configuration.dart#newcode24 lib/src/runner/configuration.dart:24: /// The parser used to parse the command-line arguments.. ...
5 years, 5 months ago (2015-07-06 20:15:10 UTC) #4
nweiz
5 years, 5 months ago (2015-07-06 20:16:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cb1dea0ffca6d360870e327eec628ee19dedf437 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698