Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1218903003: Add tests for stack chains in the browser. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stack_trace@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for stack chains in the browser. Now that dart-lang/sdk#15171 is fixed, this works! R=rnystrom@google.com Committed: https://github.com/dart-lang/stack_trace/commit/e6a2b795d74a0ab5c04cc523331e53184afb1264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+726 lines, -1196 lines) Patch
M CHANGELOG.md View 1 chunk +7 lines, -0 lines 0 comments Download
M lib/src/chain.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/chain/chain_test.dart View 1 chunk +282 lines, -0 lines 0 comments Download
A test/chain/dart2js_test.dart View 1 chunk +338 lines, -0 lines 0 comments Download
A test/chain/utils.dart View 1 chunk +93 lines, -0 lines 0 comments Download
A + test/chain/vm_test.dart View 2 chunks +5 lines, -356 lines 0 comments Download
D test/chain_test.dart View 1 chunk +0 lines, -832 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 5 months ago (2015-06-29 21:49:36 UTC) #1
Bob Nystrom
LGTM!
5 years, 5 months ago (2015-06-29 22:21:24 UTC) #2
nweiz
5 years, 5 months ago (2015-06-29 23:28:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e6a2b795d74a0ab5c04cc523331e53184afb1264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698