Issue 1218843003: dart2js cps: Cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1218843003: dart2js cps: Cleanup. (Closed)

Created:
5 years, 5 months ago by asgerf

Modified:
5 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js cps: Cleanup. Add LetCont.two constructor for convenience. Remove old code for specialized static calls to getInterceptor. This should had been done in a previous CL where the Interceptor IR node was added. Remove InvokeStatic.isEffectivelyConstant, since this was only used for interceptor and identical calls, which are no longer static calls. Remove redundant imports and use consistent parameters for SourceInformation. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/a8d36ce761772e6e384f253e58f7c9b72e49f07a

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -75 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View		11 chunks	+11 lines, -21 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	1 2	10 chunks	+10 lines, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1	5 chunks	+9 lines, -30 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart	View		1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

LGTM. Please add a little bit more description into the CL description.

5 years, 5 months ago (2015-07-02 15:46:33 UTC) #3

asgerf

5 years, 5 months ago (2015-07-02 16:01:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
a8d36ce761772e6e384f253e58f7c9b72e49f07a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1218843003: dart2js cps: Cleanup. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Apparantly getInterceptor is still invoked as a static somewhere #

Patch Set 3 : Rebase #

Messages