Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1218813011: Add handle method to ErrorResult. (Closed)

Created:
5 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 5 months ago
Reviewers:
nweiz, Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/async@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add handle method to ErrorResult. The handle method takes care of checking if the error handler function accepts two arguements or not, and calles it with error and stackTrace if possible, otherwise just with error. I noticed the pattern occuring multiple times when working with error results, so it would be better to have it handled in one place. Also changed result file to /// comments. R=sgjesse@google.com Committed: https://github.com/dart-lang/async/commit/02ec22851ac73233de02d7cf7d7cfbacd0eaab84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -138 lines) Patch
M lib/result.dart View 8 chunks +103 lines, -138 lines 0 comments Download
M test/result_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Lasse Reichstein Nielsen
5 years, 5 months ago (2015-07-02 09:18:14 UTC) #2
Søren Gjesse
lgtm You did not find and use of it inside the package itself?
5 years, 5 months ago (2015-07-02 10:16:55 UTC) #3
Lasse Reichstein Nielsen
On 2015/07/02 10:16:55, Søren Gjesse wrote: > lgtm > > You did not find and ...
5 years, 5 months ago (2015-07-02 12:32:31 UTC) #4
Lasse Reichstein Nielsen
On 2015/07/02 12:32:31, Lasse Reichstein Nielsen wrote: > On 2015/07/02 10:16:55, Søren Gjesse wrote: > ...
5 years, 5 months ago (2015-07-02 12:36:22 UTC) #5
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 02ec22851ac73233de02d7cf7d7cfbacd0eaab84 (presubmit successful).
5 years, 5 months ago (2015-07-03 10:12:00 UTC) #6
nweiz
5 years, 5 months ago (2015-07-06 20:19:38 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698