Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1218813002: Ensure correct line endings for method_mirror_source tests. (Closed)

Created:
5 years, 5 months ago by herhut
Modified:
5 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure correct line endings for method_mirror_source tests. R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/57765a89292d1c7c94dd858290aa6e4ff026ab2d

Patch Set 1 #

Patch Set 2 : added missing .gitattributes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M .gitattributes View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib/mirrors/method_mirror_source_line_ending_lf.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/lib/mirrors/method_mirror_source_line_ending_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/mirrors/method_mirror_source_other.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/lib/mirrors/method_mirror_source_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
herhut
I have added the missing tests to the list of files that have to keep ...
5 years, 5 months ago (2015-06-29 10:48:07 UTC) #1
Bill Hesse
lgtm
5 years, 5 months ago (2015-06-29 11:02:41 UTC) #2
Bill Hesse
5 years, 5 months ago (2015-06-29 11:44:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
57765a89292d1c7c94dd858290aa6e4ff026ab2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698