Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1218793002: Compute constant constructors in resolution. (Closed)

Created:
5 years, 5 months ago by Johnni Winther
Modified:
5 years, 5 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -113 lines) Patch
M pkg/compiler/lib/src/constants/expressions.dart View 5 chunks +52 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 4 chunks +25 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 16 chunks +152 lines, -48 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 35 chunks +244 lines, -55 lines 2 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 3 chunks +34 lines, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 5 months ago (2015-06-29 08:41:05 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1218793002/diff/20001/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1218793002/diff/20001/pkg/compiler/lib/src/resolution/members.dart#newcode10 pkg/compiler/lib/src/resolution/members.dart:10: NON_CONSTANT, Are we still using all caps for ...
5 years, 5 months ago (2015-06-29 10:06:10 UTC) #3
Johnni Winther
https://codereview.chromium.org/1218793002/diff/20001/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1218793002/diff/20001/pkg/compiler/lib/src/resolution/members.dart#newcode10 pkg/compiler/lib/src/resolution/members.dart:10: NON_CONSTANT, On 2015/06/29 10:06:10, sigurdm wrote: > Are we ...
5 years, 5 months ago (2015-06-29 10:47:50 UTC) #4
Johnni Winther
5 years, 5 months ago (2015-06-29 10:56:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
74d04a6a489a4bfdddfa11e724e8a4bc34eaa794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698