Issue 12184017: MetadataAnnotation should be spannable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12184017: MetadataAnnotation should be spannable. (Closed)

Created:
7 years, 10 months ago by ahe

Modified:
7 years, 10 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MetadataAnnotation should be spannable. Committed: https://code.google.com/p/dart/source/detail?r=18129

Patch Set 1 : #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -10 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js/metadata_test.dart	View	7 chunks	+32 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

Also used for deferred/lazy loading of libraries. https://codereview.chromium.org/12184017/diff/2001/dart/tests/compiler/dart2js/metadata_test.dart File dart/tests/compiler/dart2js/metadata_test.dart (right): https://codereview.chromium.org/12184017/diff/2001/dart/tests/compiler/dart2js/metadata_test.dart#newcode25 dart/tests/compiler/dart2js/metadata_test.dart:25: // TODO(ahe): ...

7 years, 10 months ago (2013-02-05 09:54:10 UTC) #1

lgtm

Expand Messages | Collapse Messages