Issue 12184013: Update status file, and file bug for FF that returns JS functions when calling document.createEleme…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12184013: Update status file, and file bug for FF that returns JS functions when calling document.createEleme… (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
kasperl, blois

CC:
reviews_dartlang.org, sra1, blois

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Update status file, and file bug for FF that returns JS functions when calling document.createElement. Committed: https://code.google.com/p/dart/source/detail?r=18049

Patch Set 1 #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/html/html.status	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/12184013/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/12184013/diff/1/tests/html/html.status#newcode279 tests/html/html.status:279: element_types_test/constructors: Fail # Issue 8293 These changes are because ...

7 years, 10 months ago (2013-02-04 19:03:22 UTC) #3

ngeoffray

7 years, 10 months ago (2013-02-04 20:04:22 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12184013/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12184013/diff/1/tests/html/html.status#newcod...
tests/html/html.status:279: element_types_test/constructors: Fail # Issue 8293
On 2013/02/04 19:03:22, blois wrote:
> These changes are because in dart2js Element.isTagSupported is now dropping an
> 'is' check and returning true when it should not. I'd prefer to fix that
> instead.

So the problem lies in the type annotation of the JS call in
_ElementFactoryProvider::createElementTag. Since it says that it returns an
Element, if you do an 'is' check on it with Element, dart2js compiles that to
true.

Expand Messages | Collapse Messages