Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 12183033: Simple parser driver example. (Closed)

Created:
7 years, 10 months ago by pquitslund
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Simple parser driver example. Committed: https://code.google.com/p/dart/source/detail?r=18097

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
A pkg/analyzer-experimental/example/parser_driver.dart View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pquitslund
7 years, 10 months ago (2013-02-05 00:06:37 UTC) #1
scheglov
lgtm https://codereview.chromium.org/12183033/diff/1/pkg/analyzer-experimental/example/parser_driver.dart File pkg/analyzer-experimental/example/parser_driver.dart (right): https://codereview.chromium.org/12183033/diff/1/pkg/analyzer-experimental/example/parser_driver.dart#newcode34 pkg/analyzer-experimental/example/parser_driver.dart:34: var scanner = new StringScanner(null, src, null); You ...
7 years, 10 months ago (2013-02-05 00:16:40 UTC) #2
pquitslund
Thanks! https://codereview.chromium.org/12183033/diff/1/pkg/analyzer-experimental/example/parser_driver.dart File pkg/analyzer-experimental/example/parser_driver.dart (right): https://codereview.chromium.org/12183033/diff/1/pkg/analyzer-experimental/example/parser_driver.dart#newcode34 pkg/analyzer-experimental/example/parser_driver.dart:34: var scanner = new StringScanner(null, src, null); On ...
7 years, 10 months ago (2013-02-05 00:24:14 UTC) #3
Brian Wilkerson
LGTM, although this is *not* how we want people to invoke the parser. This works ...
7 years, 10 months ago (2013-02-05 04:35:18 UTC) #4
pquitslund
7 years, 10 months ago (2013-02-05 05:20:41 UTC) #5
Message was sent while issue was closed.
On 2013/02/05 04:35:18, Brian Wilkerson wrote:
> LGTM, although this is *not* how we want people to invoke the parser. This
works
> in the short run, given that not everything has been ported, but eventually we
> want people to use the API in AnalysisContext. (It would be nice if that fact
> were documented.)

Indeed.  We should talk some about how this should "really look".  Can you point
me to some Java snippets that are closer and that I can use as a good jumping
off point?

Powered by Google App Engine
This is Rietveld 408576698