Issue 12183014: Resubmit reverted r17962, but, for now, only report error about unfinalized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12183014: Resubmit reverted r17962, but, for now, only report error about unfinalized (Closed)

Created:
7 years, 10 months ago by regis

Modified:
7 years, 10 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Resubmit reverted r17962, but, for now, only report error about unfinalized types if flag --error_on_malformed_type is specified. Fix one more case of unfinalized signature type. Committed: https://code.google.com/p/dart/source/detail?r=18033

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+265 lines, -123 lines)			Patch
M	runtime/lib/growable_array.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	11 chunks	+33 lines, -33 lines	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	5 chunks	+44 lines, -44 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	17 chunks	+92 lines, -40 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	6 chunks	+82 lines, -1 line	0 comments	Download
M	runtime/vm/snapshot_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

TBR

Expand Messages | Collapse Messages