Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1218223004: dart2js cps: Reanalyze subterms when they get inserted. (Closed)

Created:
5 years, 5 months ago by asgerf
Modified:
5 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Reanalyze subterms when they get inserted. This shouldn't change any visible behavior right now, but the change is needed in a bigger incoming CL. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/1b9d41c5e7e504e9e3dd6d3880d6d62d7b7eae10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -28 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 17 chunks +67 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 5 months ago (2015-07-02 13:51:37 UTC) #2
floitsch
LGTM.
5 years, 5 months ago (2015-07-02 15:38:56 UTC) #3
asgerf
5 years, 5 months ago (2015-07-02 15:49:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b9d41c5e7e504e9e3dd6d3880d6d62d7b7eae10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698