Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1218213004: pkgbuild: fix status of package_config (Closed)

Created:
5 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

pkgbuild: fix status of package_config BUG=https://github.com/dart-lang/sdk/issues/23763 Committed: https://github.com/dart-lang/sdk/commit/8f9d21b9c7a4a55825c9dd26c608bf965c5ddf31

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/pkgbuild.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
tbr - seems like the pub dependency was added after I submitted my other fix ...
5 years, 5 months ago (2015-07-01 16:53:01 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 (id:20001) manually as 8f9d21b9c7a4a55825c9dd26c608bf965c5ddf31 (presubmit successful).
5 years, 5 months ago (2015-07-01 16:53:14 UTC) #4
Bill Hesse
5 years, 5 months ago (2015-07-02 15:57:25 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698