Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1218173009: Quote comma-separated arguments in the README. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Quote comma-separated arguments in the README. It turns out that comma is a shell-active character on Windows. This makes it so that Windows users can copy-paste the invocation into their shell and have it work. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/f225cd6edc9fcc27faccd1a450b261614971023d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M README.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 5 months ago (2015-07-07 00:12:21 UTC) #1
kevmoo
lgtm
5 years, 5 months ago (2015-07-07 00:14:20 UTC) #2
nweiz
5 years, 5 months ago (2015-07-07 00:16:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f225cd6edc9fcc27faccd1a450b261614971023d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698