Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1217923002: Fix a "pub run" bug. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a "pub run" bug. When running an executable directly from the filesystem, "pub run" would sometimes fail to give it the correct package root. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/0c02113cc761ec5f142a8c41ff277505fafa5e10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M lib/src/executable.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A + test/run/loads_package_imports_in_a_dependency_test.dart View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 5 months ago (2015-06-29 20:36:52 UTC) #1
Bob Nystrom
lgtm
5 years, 5 months ago (2015-06-29 22:18:21 UTC) #2
nweiz
5 years, 5 months ago (2015-06-29 23:25:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c02113cc761ec5f142a8c41ff277505fafa5e10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698