Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 12178025: - Avoid warnings when the result of TEMP_FAILURE_RETRY is unused. (Closed)

Created:
7 years, 10 months ago by Ivan Posva
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Avoid warnings when the result of TEMP_FAILURE_RETRY is unused. Committed: https://code.google.com/p/dart/source/detail?r=18732

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -66 lines) Patch
M runtime/bin/eventhandler_macos.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/process_macos.cc View 1 12 chunks +54 lines, -54 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/platform/globals.h View 1 2 3 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ivan Posva
7 years, 10 months ago (2013-02-04 21:37:52 UTC) #1
Mads Ager (google)
How about using the USE macro instead of a C-style cast?
7 years, 10 months ago (2013-02-05 08:13:29 UTC) #2
Ivan Posva
Avoided using C-style casts as discussed. -Ivan
7 years, 10 months ago (2013-02-19 22:20:49 UTC) #3
siva
lgtm
7 years, 10 months ago (2013-02-19 22:43:02 UTC) #4
Ivan Posva
Committed patchset #3 manually as r18732 (presubmit successful).
7 years, 10 months ago (2013-02-19 22:43:30 UTC) #5
Mads Ager (google)
7 years, 10 months ago (2013-02-20 06:53:23 UTC) #6
Message was sent while issue was closed.
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698