Issue 12178019: Add a use list iterator that allows mutation of current.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12178019: Add a use list iterator that allows mutation of current. (Closed)

Created:
7 years, 10 months ago by Kevin Millikin (Google)

Modified:
7 years, 10 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a use list iterator that allows mutation of current. Add Value::Iterator that supports removing the current use from the underlying use list, including deleting it or moving it to another use list. Use it in range analysis and representation selection. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=18055

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -34 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	3 chunks	+34 lines, -32 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+17 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

7 years, 10 months ago (2013-02-04 21:38:17 UTC) #3

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/12178019/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/12178019/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.h:76: class Iterator {
public ValueObject?

Expand Messages | Collapse Messages