Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1217373005: Generic method support in element model (Closed)

Created:
5 years, 5 months ago by Brian Wilkerson
Modified:
5 years, 5 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -39 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 8 chunks +70 lines, -0 lines 4 comments Download
M pkg/analyzer/lib/src/generated/element_handle.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 11 chunks +60 lines, -19 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 12 chunks +91 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +142 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
Let me know if you see any cases that I missed, either in the element ...
5 years, 5 months ago (2015-07-06 13:11:22 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1217373005/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/1217373005/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode3639 pkg/analyzer/lib/src/generated/element.dart:3639: * A list containing all of the type ...
5 years, 5 months ago (2015-07-06 15:03:22 UTC) #3
Leaf
lgtm, thanks!
5 years, 5 months ago (2015-07-08 22:31:22 UTC) #4
Brian Wilkerson
https://codereview.chromium.org/1217373005/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/1217373005/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode3639 pkg/analyzer/lib/src/generated/element.dart:3639: * A list containing all of the type parameters ...
5 years, 5 months ago (2015-07-09 22:02:28 UTC) #5
Brian Wilkerson
5 years, 5 months ago (2015-07-10 20:53:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4d2bb641830442627ff02b5e81d30ffe36faa5f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698