Fix pkgbuild tests after adding a pubspec on pkg/compiler (fix #23750)

Fix pkgbuild tests after adding a pubspec on pkg/compiler (fix #23750)

BUG=
R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/b273d56f0d42d3832c58f691d5eec22da248d2f7

[Siggi Cherem (dart-lang), 2015-07-01 01:13:18]

sigmund@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2015-07-01 08:17:01]

lgtm

https://codereview.chromium.org/1217353002/diff/1/pkg/pkgbuild.status
File pkg/pkgbuild.status (right):

https://codereview.chromium.org/1217353002/diff/1/pkg/pkgbuild.status#newcode15
pkg/pkgbuild.status:15: pkg/compiler: PubGetError # js_ast is not published
I would change this to Skip.  We like to keep issue numbers on all failures, but
I guess just commenting a Skip with the reason is fine.
Unless you think it is a good idea to have a test that intentionally fails.

https://codereview.chromium.org/1217353002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/1217353002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:413: *      pkg/third_party/PACKAGE_NAME
Fix comment - pkg/third_party is gone. sdk/lib/_internal added.

[Siggi Cherem (dart-lang), 2015-07-01 15:18:36]

thanks Bill

https://codereview.chromium.org/1217353002/diff/1/pkg/pkgbuild.status
File pkg/pkgbuild.status (right):

https://codereview.chromium.org/1217353002/diff/1/pkg/pkgbuild.status#newcode15
pkg/pkgbuild.status:15: pkg/compiler: PubGetError # js_ast is not published
On 2015/07/01 08:17:01, Bill Hesse wrote:
> I would change this to Skip.  We like to keep issue numbers on all failures,
but
> I guess just commenting a Skip with the reason is fine.
> Unless you think it is a good idea to have a test that intentionally fails.

Done.

https://codereview.chromium.org/1217353002/diff/1/pkg/pkgbuild.status#newcode17
pkg/pkgbuild.status:17: third_party/pkg/async_await: Skip # Uses expect package.
I also noted we no longer pull this package, so this line wasn't needed anymore.

https://codereview.chromium.org/1217353002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/1217353002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:413: *      pkg/third_party/PACKAGE_NAME
On 2015/07/01 08:17:01, Bill Hesse wrote:
> Fix comment - pkg/third_party is gone. sdk/lib/_internal added.

Done.

[Siggi Cherem (dart-lang), 2015-07-01 15:19:05]

Committed patchset #2 (id:20001) manually as
b273d56f0d42d3832c58f691d5eec22da248d2f7 (presubmit successful).