Issue 12171002: Tweak SDK constraint checking a bit.

Issue 12171002: Tweak SDK constraint checking a bit. (Closed)

Created:
7 years, 10 months ago by Bob Nystrom

Modified:
7 years, 10 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Tweak SDK constraint checking a bit. Committed: https://code.google.com/p/dart/source/detail?r=18020

Patch Set 2 : Clean up Package and Pubspec a bit. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -58 lines)			Patch
utils/pub/entrypoint.dart	View	1	5 chunks	+13 lines, -12 lines	0 comments	Download
utils/pub/git_source.dart	View	1	3 chunks	+9 lines, -13 lines	0 comments	Download
utils/pub/package.dart	View	1	1 chunk	+3 lines, -20 lines	0 comments	Download
utils/pub/pubspec.dart	View	1	2 chunks	+24 lines, -0 lines	0 comments	Download
utils/pub/sdk_source.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
utils/pub/source.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
utils/pub/system_cache.dart	View	1	1 chunk	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

A couple of comments, but otherwise lgtm. https://codereview.chromium.org/12171002/diff/1/utils/pub/git_source.dart File utils/pub/git_source.dart (right): https://codereview.chromium.org/12171002/diff/1/utils/pub/git_source.dart#newcode69 utils/pub/git_source.dart:69: } Style ...

7 years, 10 months ago (2013-02-02 00:15:29 UTC) #2

Bob Nystrom

7 years, 10 months ago (2013-02-02 00:47:10 UTC) #3

Thanks!

https://codereview.chromium.org/12171002/diff/1/utils/pub/system_cache.dart
File utils/pub/system_cache.dart (right):

https://codereview.chromium.org/12171002/diff/1/utils/pub/system_cache.dart#n...
utils/pub/system_cache.dart:66: Future<Pubspec> getUncached() {
On 2013/02/02 00:15:29, nweiz wrote:
> This probably doesn't need to be a separate function anymore.

Done.

https://codereview.chromium.org/12171002/diff/1/utils/pub/system_cache.dart#n...
utils/pub/system_cache.dart:79: .then((package) => package.pubspec);;
On 2013/02/02 00:15:29, nweiz wrote:
> Style nit: extra semicolon

Done.

Expand Messages | Collapse Messages