Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1216873002: Add parsing support for generic methods (Closed)

Created:
5 years, 5 months ago by Brian Wilkerson
Modified:
5 years, 5 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : sort and format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -37 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 20 chunks +102 lines, -34 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 52 chunks +419 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
This doesn't do any (significant) error checking, but should parse the valid cases that I ...
5 years, 5 months ago (2015-06-28 17:09:19 UTC) #2
scheglov
LGTM
5 years, 5 months ago (2015-06-28 20:35:40 UTC) #3
Brian Wilkerson
Committed patchset #2 (id:20001) manually as 09fd112781b0d9a947093fa104342f9fa6fa22cc (presubmit successful).
5 years, 5 months ago (2015-06-29 15:39:21 UTC) #4
Leaf
5 years, 5 months ago (2015-06-29 21:01:58 UTC) #5
Message was sent while issue was closed.
Awesome, thanks!  LGTM too.

Powered by Google App Engine
This is Rietveld 408576698