Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1216593002: dart2js cps: Translate synthesized mixin constructors. (Closed)

Created:
5 years, 6 months ago by asgerf
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Translate synthesized mixin constructors. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/34302b132072d129289f177af67e6cb695ed794d

Patch Set 1 #

Patch Set 2 : Handle declaration-site initializers from mixed-in class #

Patch Set 3 : Rebase #

Patch Set 4 : Update status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -194 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 chunks +29 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 4 chunks +5 lines, -74 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 2 3 3 chunks +4 lines, -17 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 2 3 3 chunks +1 line, -8 lines 0 comments Download
M tests/html/html.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 10 chunks +10 lines, -61 lines 0 comments Download
M tests/lib/lib.status View 1 2 3 3 chunks +4 lines, -22 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 6 months ago (2015-06-26 11:53:03 UTC) #2
Kevin Millikin (Google)
lgtm
5 years, 5 months ago (2015-06-29 10:30:13 UTC) #3
asgerf
5 years, 5 months ago (2015-06-29 13:28:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
34302b132072d129289f177af67e6cb695ed794d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698