Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1216523003: Make BuildSourceClosuresTask explicitly dependent on LIBRARY_ELEMENT2. (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make BuildSourceClosuresTask explicitly dependent on LIBRARY_ELEMENT2. Previously the dependency was a private implementation detail of _SourceClosureTaskInputBuilder, which made it difficult to statically analyze the input/output relationships between tasks in the task model. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/46c0a977fac1a7a92872c7ca2d0c2b2dda460b8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 3 chunks +29 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-06-29 16:21:26 UTC) #2
scheglov
LGTM
5 years, 5 months ago (2015-06-29 16:41:26 UTC) #3
Paul Berry
5 years, 5 months ago (2015-06-29 16:46:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46c0a977fac1a7a92872c7ca2d0c2b2dda460b8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698