Issue 1216523003: Make BuildSourceClosuresTask explicitly dependent on LIBRARY_ELEMENT2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1216523003: Make BuildSourceClosuresTask explicitly dependent on LIBRARY_ELEMENT2. (Closed)

Created:
5 years, 5 months ago by Paul Berry

Modified:
5 years, 5 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make BuildSourceClosuresTask explicitly dependent on LIBRARY_ELEMENT2. Previously the dependency was a private implementation detail of _SourceClosureTaskInputBuilder, which made it difficult to statically analyze the input/output relationships between tasks in the task model. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/46c0a977fac1a7a92872c7ca2d0c2b2dda460b8c

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -13 lines)			Patch
	M	pkg/analyzer/lib/src/task/dart.dart	View		3 chunks	+29 lines, -13 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

5 years, 5 months ago (2015-06-29 16:46:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
46c0a977fac1a7a92872c7ca2d0c2b2dda460b8c (presubmit successful).