Issue 1216433003: Stop auto-generating Pub snapshots for testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1216433003: Stop auto-generating Pub snapshots for testing. (Closed)

Created:
5 years, 6 months ago by nweiz

Modified:
5 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Stop auto-generating Pub snapshots for testing. The git invocations in the snapshot-generation code became very flaky when run in massive parallel via the new test runner. Now a snapshot will be used if it's manually-generated, and otherwise pub will be run from source. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/b1ffbfc3520dc36b23d576053acb4d28290b8845

Patch Set 1 #

Patch Set 2 : Fix an environment variable name. #

Total comments: 2

Patch Set 3 : Code review changes #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -84 lines)			Patch
M	.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/src/io.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/test_pub.dart	View		2 chunks	+8 lines, -81 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/1216433003/diff/20001/lib/src/io.dart File lib/src/io.dart (right): https://codereview.chromium.org/1216433003/diff/20001/lib/src/io.dart#newcode488 lib/src/io.dart:488: /// "pub.test.snapshot", which is not used outside of ...

5 years, 6 months ago (2015-06-26 16:41:16 UTC) #2

nweiz

Committed patchset #3 (id:40001) manually as b1ffbfc3520dc36b23d576053acb4d28290b8845 (presubmit successful).

5 years, 6 months ago (2015-06-26 19:45:46 UTC) #4

nweiz

5 years, 6 months ago (2015-06-26 19:49:10 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1216433003/diff/20001/lib/src/io.dart
File lib/src/io.dart (right):

https://codereview.chromium.org/1216433003/diff/20001/lib/src/io.dart#newcode488
lib/src/io.dart:488: /// "pub.test.snapshot", which is not used outside of
tests.
On 2015/06/26 16:41:16, Bob Nystrom wrote:
> Update the doc comment.

Done.

Expand Messages | Collapse Messages