Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1216313003: pkg/async: cleanup unused variables in tests (Closed)

Created:
5 years, 5 months ago by kevmoo
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M test/stream_group_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M test/stream_zip_test.dart View 2 chunks +6 lines, -2 lines 1 comment Download
M test/stream_zip_zone_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 5 months ago (2015-07-01 00:44:53 UTC) #2
nweiz
https://codereview.chromium.org/1216313003/diff/1/test/stream_zip_test.dart File test/stream_zip_test.dart (right): https://codereview.chromium.org/1216313003/diff/1/test/stream_zip_test.dart#newcode179 test/stream_zip_test.dart:179: }); // Call to complete test. Why are these ...
5 years, 5 months ago (2015-07-01 00:47:24 UTC) #3
kevmoo
On 2015/07/01 00:47:24, nweiz wrote: > https://codereview.chromium.org/1216313003/diff/1/test/stream_zip_test.dart > File test/stream_zip_test.dart (right): > > https://codereview.chromium.org/1216313003/diff/1/test/stream_zip_test.dart#newcode179 > ...
5 years, 5 months ago (2015-07-01 00:53:13 UTC) #4
nweiz
LGTM On 2015/07/01 00:53:13, kevmoo wrote: > On 2015/07/01 00:47:24, nweiz wrote: > > https://codereview.chromium.org/1216313003/diff/1/test/stream_zip_test.dart ...
5 years, 5 months ago (2015-07-01 01:00:34 UTC) #5
kevmoo
5 years, 5 months ago (2015-07-01 01:10:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cb17e2c7b94536a8f2da1ef19a51353d7fbec95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698