keep old location of libraries.dart in the generated SDK (fixes 23755)

keep old location of libraries.dart in the generated SDK (fixes 23755)

R=kevmoo@google.com

Committed: https://github.com/dart-lang/sdk/commit/4ec3db6947cdbb554c395d4b98196293bf7de3bc

[Siggi Cherem (dart-lang), 2015-06-30 23:28:47]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-06-30 23:31:23]

sigmund@google.com changed reviewers:
+ brianwilkerson@google.com, kevmoo@google.com, whesse@chromium.org

[Siggi Cherem (dart-lang), 2015-06-30 23:31:24]

https://codereview.chromium.org/1216313002/diff/20001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/1216313002/diff/20001/tools/create_sdk.py#new...
tools/create_sdk.py:230: join(LIB, '_internal', 'libraries.dart'))
turns out this was easier than keeping around 2 copies. We just copy it while
generating the dart-sdk folder.

This seems to work for the source_gen case

[kevmoo, 2015-06-30 23:44:33]

https://codereview.chromium.org/1216313002/diff/40001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/1216313002/diff/40001/tools/create_sdk.py#new...
tools/create_sdk.py:223: # TODO(sigmund): stop copying it once the public
version of analyzer supports
Should likely say something about "stop supporting version <=0.25.0 of the
analyzer package

...removing this fix WILL break all old builds. Should base this on if everyone
we care about has migrated safely for a few SDK releases

[Siggi Cherem (dart-lang), 2015-06-30 23:52:15]

https://codereview.chromium.org/1216313002/diff/40001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/1216313002/diff/40001/tools/create_sdk.py#new...
tools/create_sdk.py:223: # TODO(sigmund): stop copying it once the public
version of analyzer supports
On 2015/06/30 23:44:32, kevmoo wrote:
> Should likely say something about "stop supporting version <=0.25.0 of the
> analyzer package
> 
> ...removing this fix WILL break all old builds. Should base this on if
everyone
> we care about has migrated safely for a few SDK releases

Done.

[kevmoo, 2015-07-01 00:00:21]

LGTM w/ comment nit

https://codereview.chromium.org/1216313002/diff/60001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/1216313002/diff/60001/tools/create_sdk.py#new...
tools/create_sdk.py:226: # TODO(sigmund): stop copying libraries.dart. Old
versions (<=0.25.1) of the
so 0.25.1-alpha.4

[Siggi Cherem (dart-lang), 2015-07-01 00:08:26]

Committed patchset #3 (id:60001) manually as
4ec3db6947cdbb554c395d4b98196293bf7de3bc (presubmit successful).

[Siggi Cherem (dart-lang), 2015-07-01 00:08:37]

https://codereview.chromium.org/1216313002/diff/60001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/1216313002/diff/60001/tools/create_sdk.py#new...
tools/create_sdk.py:226: # TODO(sigmund): stop copying libraries.dart. Old
versions (<=0.25.1) of the
On 2015/07/01 00:00:21, kevmoo wrote:
> so 0.25.1-alpha.4

Done.

[scheglov, 2015-07-01 00:28:26]

LGTM

[Bill Hesse, 2015-07-01 07:55:48]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2015-07-01 07:55:49]

LGTM.