Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 12163006: Added Area Element class doc. (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski
Modified:
7 years, 10 months ago
Reviewers:
Kathy Walrath
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added Area Element class doc. Committed: https://code.google.com/p/dart/source/detail?r=18052

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/dom/docs/docs.json View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Andrei Mouravski
I added this to demonstrate how this works to Lars, but might as well commit ...
7 years, 10 months ago (2013-02-01 19:21:57 UTC) #1
Kathy Walrath
some quibbles https://codereview.chromium.org/12163006/diff/2001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/12163006/diff/2001/sdk/lib/html/dartium/html_dartium.dart#newcode464 sdk/lib/html/dartium/html_dartium.dart:464: + * * [Area Element](https://developer.mozilla.org/en-US/docs/HTML/Element/area) Could we ...
7 years, 10 months ago (2013-02-01 20:58:01 UTC) #2
Andrei Mouravski
PTAL.
7 years, 10 months ago (2013-02-01 21:19:39 UTC) #3
Kathy Walrath
The new text looks good, but I only see it in one file...
7 years, 10 months ago (2013-02-01 21:53:01 UTC) #4
Kathy Walrath
lgtm Interesting, the changes *are* in the other files, too. There's just no link in ...
7 years, 10 months ago (2013-02-01 21:55:11 UTC) #5
Andrei Mouravski
7 years, 10 months ago (2013-02-04 15:50:47 UTC) #6
On 2013/02/01 21:55:11, Kathy Walrath wrote:
> lgtm
> 
> Interesting, the changes *are* in the other files, too. There's just no link
in
> the delta section.

Yeah, that's because Rietveld (Chromium Code Reviews) can't handle that large a
file. It's awful.

Thanks for review! Submitting.

Powered by Google App Engine
This is Rietveld 408576698