Fix tests to run in dart-lang/sdk.

Fix tests to run in dart-lang/sdk.

Now that pub uses the new test runner, some of its logic for running in
the Dart SDK repository needs to be updated.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/6ea9840747befeb495fc02ca3492be2032bdfbe3

[Bob Nystrom, 2015-06-30 18:33:11]

lgtm

https://codereview.chromium.org/1216163002/diff/1/lib/src/io.dart
File lib/src/io.dart (right):

https://codereview.chromium.org/1216163002/diff/1/lib/src/io.dart#newcode524
lib/src/io.dart:524: // the working directory is
"is ..."

https://codereview.chromium.org/1216163002/diff/1/lib/src/io.dart#newcode585
lib/src/io.dart:585: return
path.dirname(path.dirname(path.dirname(path.current)));
Is there a reason to prefer chained dirnames over path.join(path.current,
"../../../");?

[nweiz, 2015-06-30 19:47:30]

https://codereview.chromium.org/1216163002/diff/1/lib/src/io.dart
File lib/src/io.dart (right):

https://codereview.chromium.org/1216163002/diff/1/lib/src/io.dart#newcode524
lib/src/io.dart:524: // the working directory is
On 2015/06/30 18:33:11, Bob Nystrom wrote:
> "is ..."

Done.

https://codereview.chromium.org/1216163002/diff/1/lib/src/io.dart#newcode585
lib/src/io.dart:585: return
path.dirname(path.dirname(path.dirname(path.current)));
On 2015/06/30 18:33:11, Bob Nystrom wrote:
> Is there a reason to prefer chained dirnames over path.join(path.current,
> "../../../");?

Because path.join tries to avoid any unnecessary modification of the inputs, it
will return "${path.current}/../../..", which is uglier than actually moving up
the directories. Since this path might end up somewhere user-visible, it seems
better to keep it nice-looking.

[nweiz, 2015-06-30 19:48:01]

Committed patchset #2 (id:20001) manually as
6ea9840747befeb495fc02ca3492be2032bdfbe3 (presubmit successful).

[Bob Nystrom, 2015-06-30 20:11:10]

On 2015/06/30 19:47:30, nweiz wrote:
> https://codereview.chromium.org/1216163002/diff/1/lib/src/io.dart
> File lib/src/io.dart (right):
> 
> https://codereview.chromium.org/1216163002/diff/1/lib/src/io.dart#newcode524
> lib/src/io.dart:524: // the working directory is
> On 2015/06/30 18:33:11, Bob Nystrom wrote:
> > "is ..."
> 
> Done.
> 
> https://codereview.chromium.org/1216163002/diff/1/lib/src/io.dart#newcode585
> lib/src/io.dart:585: return
> path.dirname(path.dirname(path.dirname(path.current)));
> On 2015/06/30 18:33:11, Bob Nystrom wrote:
> > Is there a reason to prefer chained dirnames over path.join(path.current,
> > "../../../");?
> 
> Because path.join tries to avoid any unnecessary modification of the inputs,
it
> will return "${path.current}/../../..", which is uglier than actually moving
up
> the directories. Since this path might end up somewhere user-visible, it seems
> better to keep it nice-looking.

Ah, that makes sense. Sometimes, if the chain of dirnames is too long, I'll just
do:

path.normalize(path.join(path.current, "../../../"));