Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 1215753003: Work around naming conflict in analyzer's Resource class. (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Work around naming conflict in analyzer's Resource class. Commit f8ce36df557af9028ef72612a43e9942d6f16585 introduced an SDK class called "Resource", causing warnings to appear in any files that reference the analyzer class with the same name. (Fortunately there was no regression in functionality since the spec requires the name conflict to be resolved in favor of the definition that is outside the SDK). As a short term workaround to avoid the warnings, we are explicitly importing 'dart:core' and hiding the new Resource class. In a future CL, we plan to rework analyzer's Resource class in order to make some changes necessary for ".packages" file support; when that happens we will probably rename the class to avoid the name conflict. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/db6c95502a8250a036227356824527f1a4e31b23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -123 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/import_uri_contributor.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/source/optimizing_pub_package_map_provider.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/source/package_map_resolver.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/source/pub_package_map_provider.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -122 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-06-26 17:57:20 UTC) #2
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-06-26 18:35:55 UTC) #3
Paul Berry
5 years, 5 months ago (2015-06-26 20:00:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db6c95502a8250a036227356824527f1a4e31b23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698