Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1215713005: dart2js cps: Do not build type casts for casting to 'dynamic'. (Closed)

Created:
5 years, 5 months ago by asgerf
Modified:
5 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Do not build type casts for casting to 'dynamic'. Code generation assumes such redundant nodes do not occur. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/208e48ab7a7ca666808148cb70333f1c0e4935f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 5 months ago (2015-07-06 10:24:57 UTC) #2
floitsch
LGTM.
5 years, 5 months ago (2015-07-06 10:30:00 UTC) #3
asgerf
5 years, 5 months ago (2015-07-06 12:35:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
208e48ab7a7ca666808148cb70333f1c0e4935f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698