Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1215613002: dart2js: Fix encoding of field names in csp mode. (Closed)

Created:
5 years, 6 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Fix encoding of field names in csp mode. R=floitsch@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b3730bc4eb0fc8a61ff18b57e3812ec757939a9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
herhut
This has to be a list of strings, not a single string.
5 years, 6 months ago (2015-06-26 07:45:06 UTC) #1
floitsch
LGTM.
5 years, 6 months ago (2015-06-26 08:48:48 UTC) #2
herhut
5 years, 6 months ago (2015-06-26 11:00:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b3730bc4eb0fc8a61ff18b57e3812ec757939a9e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698