Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 121553003: Regression test for issue 15744 (Closed)

Created:
6 years, 11 months ago by zra
Modified:
6 years, 11 months ago
Reviewers:
kasperl, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
A tests/lib/mirrors/syntax_error_test.dart View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zra
6 years, 11 months ago (2014-01-03 19:05:45 UTC) #1
zra
Changed to remove negative_test.
6 years, 11 months ago (2014-01-03 19:23:44 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/121553003/diff/50003/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/121553003/diff/50003/tests/lib/lib.status#newcode203 tests/lib/lib.status:203: mirrors/syntax_error_test: Pass # Issue 15886. Should fail ...
6 years, 11 months ago (2014-01-03 23:55:46 UTC) #3
zra
https://codereview.chromium.org/121553003/diff/50003/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/121553003/diff/50003/tests/lib/lib.status#newcode203 tests/lib/lib.status:203: mirrors/syntax_error_test: Pass # Issue 15886. Should fail with syntax ...
6 years, 11 months ago (2014-01-03 23:59:09 UTC) #4
zra
Committed patchset #4 manually as r31460 (presubmit successful).
6 years, 11 months ago (2014-01-03 23:59:27 UTC) #5
kasperl
6 years, 11 months ago (2014-01-04 11:43:30 UTC) #6
Message was sent while issue was closed.
Awesome! This (together with the fix) should probably be merged to trunk and
eventually the 1.1 release branch so please file a "merge request" issue.

Powered by Google App Engine
This is Rietveld 408576698