Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1215293002: Remove warnings in tests, and even fix analyzer hints. (Closed)

Created:
5 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/async@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove warnings in tests, and even fix analyzer hints. Committed: https://github.com/dart-lang/async/commit/09d80b5c3d1fd5f02b3e2f26fadc903ad59ff981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -51 lines) Patch
M test/stream_completer_test.dart View 6 chunks +22 lines, -43 lines 0 comments Download
M test/stream_queue_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M test/subscription_stream_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M test/utils.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
TBR
5 years, 5 months ago (2015-07-01 10:12:02 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 09d80b5c3d1fd5f02b3e2f26fadc903ad59ff981 (presubmit successful).
5 years, 5 months ago (2015-07-01 10:12:16 UTC) #3
Søren Gjesse
5 years, 5 months ago (2015-07-01 10:14:59 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698