Issue 1215143002: Remove one fixed entry from object pool on x64 and arm64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1215143002: Remove one fixed entry from object pool on x64 and arm64. (Closed)

Created:
5 years, 5 months ago by Florian Schneider

Modified:
5 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove one fixed entry from object pool on x64 and arm64. The CallToRuntime stub is not needed as a fixed entry anymore since all stubs set up their own object pool. The UpdateStoreBuffer stub is still needed because intrinsics don't set up a normal frame. Changing that would also allow removing this entry. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/65f19d9cfc0797fa10e735f318998f0e55a47f5f

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -14 lines)			Patch
	M	runtime/vm/assembler_arm64.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
	M	runtime/vm/assembler_x64.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

5 years, 5 months ago (2015-07-01 09:08:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
65f19d9cfc0797fa10e735f318998f0e55a47f5f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages