Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1215063008: Add FutureGroup.onIdle and FutureGroup.isIdle. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -11 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/future_group.dart View 1 2 chunks +22 lines, -1 line 0 comments Download
M test/future_group_test.dart View 7 chunks +106 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 5 months ago (2015-07-01 20:52:28 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1215063008/diff/1/lib/src/future_group.dart File lib/src/future_group.dart (right): https://codereview.chromium.org/1215063008/diff/1/lib/src/future_group.dart#newcode47 lib/src/future_group.dart:47: final _onIdleController = new StreamController.broadcast(sync: true); Could it ...
5 years, 5 months ago (2015-07-02 09:18:36 UTC) #3
nweiz
Code review changes
5 years, 5 months ago (2015-07-06 20:23:15 UTC) #4
nweiz
https://codereview.chromium.org/1215063008/diff/1/lib/src/future_group.dart File lib/src/future_group.dart (right): https://codereview.chromium.org/1215063008/diff/1/lib/src/future_group.dart#newcode47 lib/src/future_group.dart:47: final _onIdleController = new StreamController.broadcast(sync: true); On 2015/07/02 09:18:35, ...
5 years, 5 months ago (2015-07-06 20:23:18 UTC) #5
nweiz
5 years, 5 months ago (2015-07-06 20:24:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f17906cd2a0dee8956a312b30bd04ef9b12c161f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698