Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1214823003: Move SdkExtUriResolver from analysis_server to analyzer so it can be used in analyzer_cli (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move SdkExtUriResolver from analysis_server to analyzer so it can be used in analyzer_cli BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/6ecf960c5eb178d24e30664dfe909f2e555e2593

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -270 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/src/sdk_ext.dart View 1 chunk +0 lines, -167 lines 0 comments Download
D pkg/analysis_server/test/src/sdk_ext_test.dart View 1 chunk +0 lines, -97 lines 0 comments Download
M pkg/analysis_server/test/src/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
A + pkg/analyzer/lib/source/sdk_ext.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer/test/source/sdk_ext_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/source/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 5 months ago (2015-07-08 17:15:17 UTC) #2
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-08 17:23:33 UTC) #3
Cutch
5 years, 5 months ago (2015-07-08 17:28:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6ecf960c5eb178d24e30664dfe909f2e555e2593 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698