Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 12148002: Resubmit "Adding ease-of-use methods to HttpRequest." (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Resubmit "Adding ease-of-use methods to HttpRequest." Fixing the dependent pkg/intl code. This is the same as my previous CL, but with the modification to pkg/intl/lib/src/http_request_data_reader.dart BUG= Committed: https://code.google.com/p/dart/source/detail?r=17949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -68 lines) Patch
M pkg/intl/lib/src/http_request_data_reader.dart View 1 chunk +1 line, -8 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +66 lines, -15 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +66 lines, -15 lines 0 comments Download
M tests/html/xhr_test.dart View 2 chunks +64 lines, -15 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 2 chunks +70 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 10 months ago (2013-01-31 22:32:05 UTC) #1
Alan Knight
Nice. lgtm.
7 years, 10 months ago (2013-01-31 22:33:40 UTC) #2
Emily Fortuna
7 years, 10 months ago (2013-01-31 22:35:54 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698