Issue 1214773003: Fix a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1214773003: Fix a crash. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a crash. The compact reporter was canceling a timer when it might not have been initialized. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/be3f2db502d5482d82bf6b1ad5295a39c46edb7c

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/runner/reporter/compact.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 5 months ago (2015-07-06 20:11:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
be3f2db502d5482d82bf6b1ad5295a39c46edb7c (presubmit successful).