Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214723010: dart2js: Make it more obvious how rti-only needed classes work. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
Reviewers:
karlklose, herhut
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Make it more obvious how rti-only needed classes work. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/46d7004fe884b86feb9a3d311b289288985b21b9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 6 chunks +9 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
5 years, 5 months ago (2015-07-07 12:57:53 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1214723010/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart File pkg/compiler/lib/src/js_emitter/code_emitter_task.dart (right): https://codereview.chromium.org/1214723010/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart#newcode25 pkg/compiler/lib/src/js_emitter/code_emitter_task.dart:25: Set<ClassElement> rtiOnlyNeededClasses; Maybe 'classesOnlyNeededForRti'?
5 years, 5 months ago (2015-07-07 13:40:37 UTC) #4
floitsch
https://codereview.chromium.org/1214723010/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart File pkg/compiler/lib/src/js_emitter/code_emitter_task.dart (right): https://codereview.chromium.org/1214723010/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart#newcode25 pkg/compiler/lib/src/js_emitter/code_emitter_task.dart:25: Set<ClassElement> rtiOnlyNeededClasses; On 2015/07/07 13:40:37, karlklose wrote: > Maybe ...
5 years, 5 months ago (2015-07-07 13:48:37 UTC) #5
floitsch
5 years, 5 months ago (2015-07-07 13:51:33 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
46d7004fe884b86feb9a3d311b289288985b21b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698