Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1214643003: dart2js cps: Set receiver type in type propagation. (Closed)

Created:
5 years, 6 months ago by asgerf
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Set receiver type in type propagation. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/4f8d7b42d25fc2f797e1dcd85f9f54b7c1c88f28

Patch Set 1 #

Patch Set 2 : Use subclass, not exact #

Total comments: 2

Patch Set 3 : Remove JavaScriptBackend + update status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 3 chunks +13 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
asgerf
5 years, 6 months ago (2015-06-26 12:37:38 UTC) #2
Kevin Millikin (Google)
I wonder if TypeMaskSystem.backend should be deleted or used somewhere. LGTM when that is sorted ...
5 years, 5 months ago (2015-06-29 10:35:35 UTC) #3
asgerf
https://codereview.chromium.org/1214643003/diff/20001/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1214643003/diff/20001/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode28 pkg/compiler/lib/src/cps_ir/type_propagation.dart:28: final JavaScriptBackend backend; On 2015/06/29 10:35:35, Kevin Millikin (Google) ...
5 years, 5 months ago (2015-06-29 13:46:19 UTC) #4
asgerf
5 years, 5 months ago (2015-06-29 14:01:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
4f8d7b42d25fc2f797e1dcd85f9f54b7c1c88f28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698