Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1214343004: Run pub tests on the pub bots. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run pub tests on the pub bots. The pub bot script just runs the new test runner against the repo versions of all the packages. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/49948accadee3b8f49467440acc6c9e85dfc647e

Patch Set 1 #

Patch Set 2 : Update deps. #

Patch Set 3 : Fix dart_style tests. #

Patch Set 4 : Use the right dart_style version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -67 lines) Patch
M DEPS View 1 2 3 5 chunks +13 lines, -6 lines 0 comments Download
M tools/bots/bot.py View 1 2 3 chunks +32 lines, -2 lines 0 comments Download
M tools/bots/pkg.py View 1 2 3 chunks +26 lines, -27 lines 0 comments Download
M tools/bots/pub.py View 1 2 2 chunks +2 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
5 years, 5 months ago (2015-06-30 20:15:53 UTC) #2
Bill Hesse
LGTM. I have filed an issue to create the mirror repos - waiting on response.
5 years, 5 months ago (2015-07-07 08:00:54 UTC) #3
nweiz
5 years, 5 months ago (2015-07-07 20:14:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
49948accadee3b8f49467440acc6c9e85dfc647e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698