Hook for overriding the creation of a package resolver

Hook for overriding the creation of a package resolver

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/bdfc16a14677355ed81f3b759e1bdd6359a5a4eb

[Brian Wilkerson, 2015-07-06 17:40:57]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-07-06 19:41:47]

lgtm

https://codereview.chromium.org/1214243005/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/uri/resolver_provider.dart (right):

https://codereview.chromium.org/1214243005/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/uri/resolver_provider.dart:12: * kind of URI within the
given folder.
Although technically there is nothing forcing the client to create a UriResolver
that resolves package URI's, the expectation is that that's what they will do
(as opposed to creating a FileUriResolver or some other such nonsense).  If they
don't create a UriResolver that resolves package URI's, they will get strange
and probably unexpected behaviors (since the analysis server uses a non-null
ResolverProvider as a signal that it should skip its default package resolution
mechanism).

I think we should explicitly document this expectation to avoid confusion, e.g.
'This function should return a UriResolver that resolves "package:" URI's.'

Also, this comment document the behavior you've implemented at line 444 of
context_manager.dart, namely that the resolver provider may return null to cause
the analysis server to fall back on its standard package resolution mechanism.

[Brian Wilkerson, 2015-07-06 20:06:37]

Committed patchset #2 (id:20001) manually as
bdfc16a14677355ed81f3b759e1bdd6359a5a4eb (presubmit successful).

[Brian Wilkerson, 2015-07-06 20:07:18]

https://codereview.chromium.org/1214243005/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/uri/resolver_provider.dart (right):

https://codereview.chromium.org/1214243005/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/uri/resolver_provider.dart:12: * kind of URI within the
given folder.
Done