Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1213723007: Update to test package, make test work on dart2js. (Closed)

Created:
5 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/collection.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update to test package, make test work on dart2js. The equality test was missing the status file that marked it as failing on dart2js. Rewrote it to not compare doubles to integers and expect them to not be identical. R=sgjesse@google.com Committed: https://github.com/dart-lang/collection/commit/79ebc6fc2dae581cb23ad50a5c600c1b7dd132f8

Patch Set 1 #

Patch Set 2 : Also update version. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -60 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/algorithms_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/canonicalized_map_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/equality_test.dart View 2 chunks +60 lines, -49 lines 2 comments Download
M test/iterable_zip_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/priority_queue_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/queue_list_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M test/unmodifiable_collection_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/wrapper_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Lasse Reichstein Nielsen
5 years, 5 months ago (2015-07-01 12:14:01 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/1213723007/diff/20001/test/equality_test.dart File test/equality_test.dart (left): https://codereview.chromium.org/1213723007/diff/20001/test/equality_test.dart#oldcode17 test/equality_test.dart:17: expect(iterId.equals(l1, l2), isFalse); /// 01: ok Are these ...
5 years, 5 months ago (2015-07-01 12:23:26 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 79ebc6fc2dae581cb23ad50a5c600c1b7dd132f8 (presubmit successful).
5 years, 5 months ago (2015-07-03 12:52:55 UTC) #4
Lasse Reichstein Nielsen
5 years, 5 months ago (2015-07-03 12:53:01 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1213723007/diff/20001/test/equality_test.dart
File test/equality_test.dart (left):

https://codereview.chromium.org/1213723007/diff/20001/test/equality_test.dart...
test/equality_test.dart:17: expect(iterId.equals(l1, l2), isFalse);  /// 01: ok
They were basically left-overs because the status file was not brought into the
package repository when it was moved out of the sdk.

Powered by Google App Engine
This is Rietveld 408576698