Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212933003: Observatory improvements for exploring compiled code. (Closed)

Created:
5 years, 5 months ago by rmacnak
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Observatory improvements for exploring compiled code. - Views for ObjectPool, Instructions, ICData. - Allow querying retained size of non-Instances. - References to non-Dart functions as links. - Find ic data array from a Function. - Fix NPE when current token position in a script inset cannot be mapped. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f84461ed482cd299186f3160f7404b1f492af4fd

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -100 lines) Patch
M runtime/observatory/lib/elements.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/elements.html View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/code_view.html View 1 2 2 chunks +32 lines, -26 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_ref.dart View 1 chunk +13 lines, -17 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 2 chunks +6 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/observatory/lib/src/elements/icdata_view.dart View 1 chunk +8 lines, -7 lines 0 comments Download
A runtime/observatory/lib/src/elements/icdata_view.html View 1 chunk +63 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/elements/instructions_view.dart View 1 chunk +7 lines, -7 lines 0 comments Download
A + runtime/observatory/lib/src/elements/instructions_view.html View 1 chunk +24 lines, -6 lines 0 comments Download
A runtime/observatory/lib/src/elements/objectpool_view.dart View 1 1 chunk +43 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/objectpool_view.html View 1 chunk +57 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 2 chunks +9 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/service_ref.html View 1 chunk +23 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 1 chunk +19 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 13 chunks +98 lines, -9 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 5 chunks +53 lines, -4 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 5 months ago (2015-06-26 20:54:41 UTC) #2
Cutch
lgtm
5 years, 5 months ago (2015-06-26 21:09:45 UTC) #3
rmacnak
5 years, 5 months ago (2015-06-26 21:29:55 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
f84461ed482cd299186f3160f7404b1f492af4fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698