Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1212823002: Fix some tests and exclude others from CRLF rewriting. (Closed)

Created:
5 years, 6 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some tests and exclude others from CRLF rewriting. R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/225be754989d01f59c25dfc8803c3b2ded36239f

Patch Set 1 #

Patch Set 2 : Fix utf8 encoded expected string. #

Patch Set 3 : Add comments to trigger update of files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M .gitattributes View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M pkg/js_ast/test/printer_callback_test.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/literal_string_juxtaposition_test.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/string_interpolation_dynamic_test.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/string_interpolation_test.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/html/svgelement_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/multiline_strings_test.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/raw_string_test.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/convert/json_pretty_test.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/convert/utf84_test.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download
M tests/lib/mirrors/method_mirror_source_line_ending_cr.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/method_mirror_source_line_ending_crlf.dart View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
herhut
5 years, 6 months ago (2015-06-26 11:55:20 UTC) #1
Bill Hesse
LGTM.
5 years, 6 months ago (2015-06-26 12:06:06 UTC) #2
Bill Hesse
On 2015/06/26 12:06:06, Bill Hesse wrote: > LGTM. I think there is a mistake in ...
5 years, 6 months ago (2015-06-26 12:17:33 UTC) #3
herhut
On 2015/06/26 12:17:33, Bill Hesse wrote: > On 2015/06/26 12:06:06, Bill Hesse wrote: > > ...
5 years, 6 months ago (2015-06-26 12:28:35 UTC) #4
Bill Hesse
LGTM, but one of the files is not displayable in the review tool: https://codereview.chromium.org/1212823002/diff/40001/tests/lib/mirrors/method_mirror_source_line_ending_cr.dart?context=10&column_width=80&tab_spaces=8
5 years, 6 months ago (2015-06-26 12:31:37 UTC) #5
herhut
On 2015/06/26 12:31:37, Bill Hesse wrote: > LGTM, but one of the files is not ...
5 years, 6 months ago (2015-06-26 12:39:36 UTC) #6
herhut
5 years, 6 months ago (2015-06-26 12:40:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
225be754989d01f59c25dfc8803c3b2ded36239f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698