Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1212683002: AST changes necessary for generic method support (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -91 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 42 chunks +176 lines, -27 lines 4 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 3 chunks +25 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 21 chunks +40 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 5 chunks +38 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 6 chunks +48 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
5 years, 6 months ago (2015-06-25 23:49:20 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1212683002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/1212683002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode8409 pkg/analyzer/lib/src/generated/ast.dart:8409: * The type parameters associated with the method, ...
5 years, 6 months ago (2015-06-26 01:33:50 UTC) #3
Leaf
lgtm, thanks!
5 years, 6 months ago (2015-06-26 18:07:24 UTC) #4
Brian Wilkerson
https://codereview.chromium.org/1212683002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/1212683002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode8409 pkg/analyzer/lib/src/generated/ast.dart:8409: * The type parameters associated with the method, or ...
5 years, 6 months ago (2015-06-26 19:07:35 UTC) #5
Brian Wilkerson
5 years, 6 months ago (2015-06-26 19:07:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b48abedfd69867bef3b256f5e2a1d8a9494aac5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698